Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rds]: Add dbParameterGroupNameSelector to ClusterInstance #1083

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

ytsarev
Copy link
Collaborator

@ytsarev ytsarev commented Jan 11, 2024

Description of your changes

  • Add dbParameterGroupNameSelector to ClusterInstance

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

uptest below

@ytsarev
Copy link
Collaborator Author

ytsarev commented Jan 11, 2024

/test-examples="examples/rds/instance.yaml"

@ytsarev
Copy link
Collaborator Author

ytsarev commented Jan 15, 2024

It looks like parameterGroupNameSelector to Instance was added in #1037 so I am rebasing this PR leaving only dbParameterGroupNameSelector to ClusterInstance part

@ytsarev
Copy link
Collaborator Author

ytsarev commented Jan 15, 2024

/test-examples="examples/rds/clusterinstance.yaml"

@ytsarev
Copy link
Collaborator Author

ytsarev commented Jan 15, 2024

/test-examples="examples/rds/clusterinstance.yaml"

@ytsarev
Copy link
Collaborator Author

ytsarev commented Jan 15, 2024

/test-examples="examples/rds/clusterinstance.yaml"

@ytsarev ytsarev changed the title [rds]: Add missing selectors [rds]: Add dbParameterGroupNameSelector to ClusterInstance Jan 16, 2024
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ytsarev, LGTM.

@ytsarev ytsarev merged commit b4bbf97 into crossplane-contrib:main Jan 16, 2024
10 checks passed
@ytsarev ytsarev deleted the rds-add-selectors branch January 16, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants